----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1552/ -----------------------------------------------------------
Review request for Default. Description ------- Changeset 9354:4688155ee5d9 --------------------------- o3: FIx issue with LLSC ordering and speculation This patch unlocks the cpu-local monitor when the CPU sees a snoop to a locked address. Previously we relied on the cache to handle the locking for us, however some users on the gem5 mailing list reported a case where the cpu speculatively executes a ll operation after a pending sc operation in the pipeline and that makes the cache monitor valid. This should handle that case by invaliding the local monitor. Diffs ----- src/arch/alpha/locked_mem.hh 844f9e724343 src/arch/arm/locked_mem.hh 844f9e724343 src/arch/mips/locked_mem.hh 844f9e724343 src/arch/power/locked_mem.hh 844f9e724343 src/arch/sparc/locked_mem.hh 844f9e724343 src/arch/x86/locked_mem.hh 844f9e724343 src/cpu/o3/lsq_unit_impl.hh 844f9e724343 Diff: http://reviews.gem5.org/r/1552/diff/ Testing ------- Thanks, Ali Saidi _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
