----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1561/#review3737 -----------------------------------------------------------
Ship it! Ship It! - Anthony Gutierrez On Dec. 6, 2012, 12:34 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1561/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2012, 12:34 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9400:4a48b644d5c8 > --------------------------- > cpu: Correctly call parent on switchOut() and takeOverFrom() > > This patch cleans up the CPU switching functionality by making sure > that CPU models consistently call the parent on switchOut() and > takeOverFrom(). This has the following implications that might alter > current functionality: > > * The call to BaseCPU::switchout() in the O3 CPU is moved from > signalDrained() (!) to switchOut(). > > * A call to BaseSimpleCPU::switchOut() is introduced in the simple > CPUs. > > > Diffs > ----- > > src/cpu/o3/cpu.cc 844f9e724343 > src/cpu/simple/atomic.cc 844f9e724343 > src/cpu/simple/timing.cc 844f9e724343 > > Diff: http://reviews.gem5.org/r/1561/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
