> On May 15, 2012, 12:45 p.m., Marc Orr wrote: > > It seems that none of the instructions that move things on/off the floating > > point stack are implemented in the simulator (fld, fst, fstp, fxchg). Does > > it make sense to commit this code?
Check out src/arch/x86/isa/insts/x87/data_transfer_and_conversion/load_or_store_floating_point.py. I think this patch should be committed as is. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/593/#review2690 ----------------------------------------------------------- On March 17, 2011, 4:07 p.m., Lisa Hsu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/593/ > ----------------------------------------------------------- > > (Updated March 17, 2011, 4:07 p.m.) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Description > ------- > > X86: fsincos: Another patch from Vince Weaver > > > Diffs > ----- > > src/arch/x86/isa/decoder/x87.isa 2e269d6fb3e6 > > src/arch/x86/isa/insts/x87/transcendental_functions/trigonometric_functions.py > 2e269d6fb3e6 > src/arch/x86/isa/microops/fpop.isa 2e269d6fb3e6 > > Diff: http://reviews.gem5.org/r/593/diff/ > > > Testing > ------- > > > Thanks, > > Lisa Hsu > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
