> On Dec. 18, 2012, 4:02 p.m., Nilay Vaish wrote: > > src/cpu/testers/traffic_gen/traffic_gen.hh, line 547 > > <http://reviews.gem5.org/r/1576/diff/1/?file=32768#file32768line547> > > > > Do you realize that the class InputStream has a variable named trace? > > It is confusing two variables of same name in a file.
Yeah I realize. It still seemed like a sensible choice given that the two classes are quite simple. I'm happy to rename one or the other if you'd like to see that done. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1576/#review3758 ----------------------------------------------------------- On Dec. 6, 2012, 8:21 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1576/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2012, 8:21 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9371:a9e189316c20 > --------------------------- > cpu: Encapsulate traffic generator input in a stream > > This patch encapsulates the traffic generator input in a stream class > such that the parsing is not visible to the trace generator. The > change takes us one step closer to using protobuf-based input traces > for the trace replay. > > The functionality of the current input stream is identical to what it > was, and the ASCII format remains the same for now. > > > Diffs > ----- > > src/cpu/testers/traffic_gen/traffic_gen.hh 844f9e724343 > src/cpu/testers/traffic_gen/traffic_gen.cc 844f9e724343 > > Diff: http://reviews.gem5.org/r/1576/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
