-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1575/#review3770
-----------------------------------------------------------

Ship it!


Ship It!

- Nilay Vaish


On Dec. 12, 2012, 6:52 a.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1575/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 6:52 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Description
> -------
> 
> Changeset 9370:7ee9c15a253f
> ---------------------------
> base: Add wrapped protobuf input stream
> 
> This patch adds support for inputting protobuf messages through a
> ProtoInputStream which hides the internal streams used by the
> library. The stream is created based on the name of an input file and
> optionally includes decompression using gzip.
> 
> The input stream will start by getting a magic number from the file,
> and also verify that it matches with the expected value. Once opened,
> messages can be read incrementally from the stream, returning
> true/false until an error occurs or the end of the file is reached.
> 
> 
> Diffs
> -----
> 
>   src/proto/protoio.hh PRE-CREATION 
>   src/proto/protoio.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/1575/diff/
> 
> 
> Testing
> -------
> 
> util/regress all passing (disregarding t1000 and eio)
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to