> On Jan. 3, 2013, 7:37 a.m., Nilay Vaish wrote: > > src/cpu/testers/traffic_gen/traffic_gen.cc, line 527 > > <http://reviews.gem5.org/r/1577/diff/2/?file=32829#file32829line527> > > > > Can we not directly read a trace element? Creating a Packet seems > > unnecessary.
The read member function relies on the protobuf Message hierarchy and thus needs a reference to a protobuf Message class. I hope that answers the question as to why it looks the way it does. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1577/#review3769 ----------------------------------------------------------- On Dec. 12, 2012, 6:54 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1577/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 6:54 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9372:2b774df97e24 > --------------------------- > cpu: Add support for protobuf input for the trace generator > > This patch adds support for reading input traces encoded using > protobuf according to what is done in the CommMonitor. > > A follow-up patch adds a Python script that can be used to convert the > previously used ASCII traces to protobuf equivalents. The appropriate > regression input is updated as part of this patch. > > > Diffs > ----- > > src/cpu/testers/traffic_gen/SConscript 844f9e724343 > src/cpu/testers/traffic_gen/traffic_gen.hh 844f9e724343 > src/cpu/testers/traffic_gen/traffic_gen.cc 844f9e724343 > tests/configs/tgen-simple-dram.py 844f9e724343 > tests/configs/tgen-simple-mem.py 844f9e724343 > tests/quick/se/70.tgen/tgen-simple-mem.trc 844f9e724343 > > Diff: http://reviews.gem5.org/r/1577/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
