> On Jan. 3, 2013, 7:48 a.m., Nilay Vaish wrote: > > src/proto/SConscript, line 42 > > <http://reviews.gem5.org/r/1574/diff/2/?file=32822#file32822line42> > > > > Shouldn't this directory be in the src/mem directory?
I would say no as we will also be using the proto support for CPU instruction tracing amongst other things. We could even envision using protobuf for the checkpoints in the future :-) The only bit that would be suitable for the mem directory would be the packet.proto, but I would prefer to keep that in the same place as the rest. Sensible enough? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1574/#review3771 ----------------------------------------------------------- On Dec. 12, 2012, 6:51 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1574/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 6:51 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9369:aa9d2425a301 > --------------------------- > mem: Add tracing support in the communication monitor > > This patch adds packet tracing to the communication monitor using a > protobuf as the mechanism for creating the trace. > > If no file is specified, then the tracing is disabled. If a file is > specified, then for every packet that is successfully sent, a protobuf > message is serialized to the file. > > > Diffs > ----- > > src/base/output.hh 844f9e724343 > src/base/output.cc 844f9e724343 > src/mem/CommMonitor.py 844f9e724343 > src/mem/SConscript 844f9e724343 > src/mem/comm_monitor.hh 844f9e724343 > src/mem/comm_monitor.cc 844f9e724343 > src/proto/SConscript PRE-CREATION > src/proto/packet.proto PRE-CREATION > tests/configs/tgen-simple-mem.py 844f9e724343 > > Diff: http://reviews.gem5.org/r/1574/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
