> On Jan. 14, 2013, 11:10 a.m., Ali Saidi wrote: > > this seems ok, but I would assume that this would work in SE mode too. Is > > that not the case? > >
ahh.. I see how a profileEvent is only ever created for an FullSsytem execution, but in that case why does this matter? Could you ever get into the if block? - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1630/#review3825 ----------------------------------------------------------- On Jan. 14, 2013, 11 a.m., Derek Hower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1630/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2013, 11 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9476:353b7376381d > --------------------------- > cpu: profileEvent access code is modified to be executed only when FullSystem > is on > > *Note* This patch was created by Hyeran Jeon ([email protected]) > > > Diffs > ----- > > src/cpu/base.cc 794711cac18b0b5b47782675d45b886f2c31449c > > Diff: http://reviews.gem5.org/r/1630/diff/ > > > Testing > ------- > > > Thanks, > > Derek Hower > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
