----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1608/#review3845 -----------------------------------------------------------
configs/common/CacheConfig.py <http://reviews.gem5.org/r/1608/#comment3708> Ali, for how many different cpu configurations are you ready to carry out this analysis? There can be inifinitly many such configurations and this case-based analysis is not the way to go. Either we should remove this reference to arm_detailed, or figure out some other way to do this. - Nilay Vaish On Jan. 7, 2013, 11:31 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1608/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2013, 11:31 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9457:fd01ef3f4a58 > --------------------------- > config: Remove O3 dependencies > > The default cache configuration script currently import the O3_ARM_v7a > model configuration, which depends on the O3 CPU. This breaks if gem5 > has been compiled without O3 support. This changeset removes the > dependency by only importing the model if it is requested by the > user. As a bonus, it actually removes some code duplication in the > configuration scripts. > > > Diffs > ----- > > configs/common/CacheConfig.py 56610ab73040 > > Diff: http://reviews.gem5.org/r/1608/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
