----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1651/#review3877 -----------------------------------------------------------
one minor thing, then happy. src/arch/arm/linux/system.cc <http://reviews.gem5.org/r/1651/#comment3731> I think this needs a bit more error checking. You should do the dynamic cast and then check success, after that you should call addBootCmdLine. With this code if the dynamic cast fails the program will crash. - Ali Saidi On Jan. 17, 2013, 8:09 a.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1651/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2013, 8:09 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9475:4d7491b3a5f2 > --------------------------- > loader: add a flattened device tree blob (dtb) object > > this adds a dtb_object so the loader can load in the dtb > file for linux/android ARM kernels. > > > Diffs > ----- > > src/base/loader/object_file.cc 23c3e1c0e9e47c39733f7e267bf0b6a05b082059 > src/base/SConscript 23c3e1c0e9e47c39733f7e267bf0b6a05b082059 > src/base/loader/dtb_object.hh PRE-CREATION > src/base/loader/dtb_object.cc PRE-CREATION > src/arch/arm/linux/system.cc 23c3e1c0e9e47c39733f7e267bf0b6a05b082059 > > Diff: http://reviews.gem5.org/r/1651/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
