----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1663/#review3884 -----------------------------------------------------------
Ship it! Two very minor things if you don't mind fixing it before committing: A full stop at the end of the summary and "quite" instead of quiet in the description. - Andreas Hansson On Jan. 22, 2013, 1:51 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1663/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2013, 1:51 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9482:188525ba03fb > --------------------------- > arm: fix some fp comparisons that worked by accident. > > The explict tests in the follwing fp comparison operations were > incorrect as they checked for only signaling NaNs and not quite-NaNs > as well. When compiled with gcc, the comparison generates a fp exception > that causes the FE_INVALID flag to be set and we check for it, so even > though the check was incorrect, the correct exception was set. With clang > this behavior seems to not occur. The checks are updated to test for nans and > the behavior is now correct with both clang and gcc. > > > Diffs > ----- > > src/arch/arm/isa/insts/neon.isa f9e76b1eb79a > > Diff: http://reviews.gem5.org/r/1663/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
