----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1606/#review3893 -----------------------------------------------------------
Ship it! In general I really love this. The arm_detailed CPU object has always been pretty ugly IMO, so this change just makes the ugliness stand out even more because now there's less surrounding ugliness to obscure it ;). Since you're not introducing any ugliness that wasn't already there, I'm OK with committing this as is and trying to solve the problem described below separately. configs/common/CpuConfig.py <http://reviews.gem5.org/r/1606/#comment3766> This special-casing is kind of ugly... is the basic problem that m5.objects only has C++-based objects? Is there a way to get a more comprehensive list of defined subclasses of BaseCPU or SimObject by constructing a list in the metaclass constructor, or something? - Steve Reinhardt On Jan. 7, 2013, 11:30 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1606/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2013, 11:30 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9455:969ab2ed5cfa > --------------------------- > config: Cleanup CPU configuration > > The CPUs supported by the configuration scripts used to be > hard-coded. This was not ideal for several reasons. For example, the > configuration scripts depend on all CPU models even though only a > subset might have been compiled. > > This changeset adds a new module to the configuration scripts that > automatically discovers the available CPU models from the compiled > SimObjects. As a nice bonus, the use of introspection allows us to > automatically generate a list of available CPU models suitable for > printing. This list is augmented with the Python doc string from the > underlying class if available. > > > Diffs > ----- > > configs/common/CpuConfig.py PRE-CREATION > configs/common/Options.py 56610ab73040 > configs/common/Simulation.py 56610ab73040 > > Diff: http://reviews.gem5.org/r/1606/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
