----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1641/#review3905 -----------------------------------------------------------
Looks good. Make me think that we should have a harmonic mean for completeness. Seems like it would be relatively easy to add this to the distribution stat as well. - Nathan Binkert On Jan. 15, 2013, 10:30 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1641/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2013, 10:30 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9494:5744a86325ec > --------------------------- > stats: Add the geometric mean to the histogram > > This patch adds the geometric mean to the histogram stat. This requires the > sum of logs of individual samples to be used. This is already calculated in > C++ and therefore simply needs to be passed into the python. > > The geometric mean is written to the text based output, whereas only the sum > of > logs of individual samples is written to the SQL database. This is done as the > geometric mean can be calculated offline. > > > Diffs > ----- > > src/python/m5/stats/__init__.py 5532a1642108 > src/python/m5/stats/display.py PRE-CREATION > src/python/m5/stats/info.py PRE-CREATION > src/python/m5/stats/sql.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/1641/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
