> On Jan. 25, 2013, 9:53 a.m., Nilay Vaish wrote: > > Seems fine to me.
Now I think this should be folded in to SQLite patch that has been posted as well. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1645/#review3913 ----------------------------------------------------------- On Jan. 15, 2013, 10:34 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1645/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2013, 10:34 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9498:f69f7b67823f > --------------------------- > stats: Add length of all stats to the SQL stats table > > This patch adds a field to the stats table in the SQL database which stores > the length of the stat. This is required to successfully re-inject data into > gem5's stats system after storing it in SQL. It also ensures that we are able > to recreate all stats post simulation, even if they were not written to the > database due to being either NaN or zero. > > > Diffs > ----- > > src/python/m5/stats/sql.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/1645/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
