> On Jan. 25, 2013, 9:20 a.m., Nathan Binkert wrote: > > > > Nathan Binkert wrote: > Also continious -> contiguous
Changed. > On Jan. 25, 2013, 9:20 a.m., Nathan Binkert wrote: > > src/python/m5/stats/display.py, line 435 > > <http://reviews.gem5.org/r/1640/diff/1/?file=33207#file33207line435> > > > > This doesn't make sense to me. You should be registering a > > SparseHistogram (or whatever it is called), and then you don't need the > > junk for checking. Changed this to use "SparseHist" in the place of "Statistic". - Sascha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1640/#review3903 ----------------------------------------------------------- On Jan. 29, 2013, 2:37 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1640/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 2:37 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9517:a625622cd8a1 > --------------------------- > stats: Add sparse histogram to python stats > > This patch adds the sparse histogram to the python stats. This histogram is > not contiguous, and values are stored as an std::map in C++. When this is > moved into python using SWIG it is stored as a python dictionary. > > When generating the text based statistics output, the histogram is stored > in the same way as in the old C++ based statistics system. > > When generating the SQL based output the sparse histogram is stored into > a separate table. This is neccessary as the columns required to store the > histogram are not compatible with any other other distributions. > > Currently the sparse histogram is only used in the communication monitor to > store the address map. > > > Diffs > ----- > > src/python/m5/stats/__init__.py 5532a1642108 > src/python/m5/stats/display.py PRE-CREATION > src/python/m5/stats/info.py PRE-CREATION > src/python/m5/stats/sql.py PRE-CREATION > src/python/swig/stats.i 5532a1642108 > util/stats/extractSQLStats.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/1640/diff/ > > > Testing > ------- > > Ran with CommMonitor > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
