> On Jan. 25, 2013, 10:12 a.m., Nilay Vaish wrote: > > src/python/m5/main.py, line 291 > > <http://reviews.gem5.org/r/1638/diff/2/?file=33514#file33514line291> > > > > Why do you want this check here? > > Sascha Bischoff wrote: > If both the text-based stats and the sql stats are disabled, then gem5 > will not produce any stats. In my mind, this is wrong. Do you think we should > just warn, rather than calling fatal?
What I am trying to suggest is that the check used here it self is not sufficient to ensure that whether or not the stats will get collected properly. Consider a situtation in which there are more checks that need to be carried before ensuring that the stats text file can actually be used. You would not want to replicate those checks in both places (here and below). Instead use a boolean variable that is initialized to false and then it is changed to true if the stats can be recorded in at least one format. Later, on the basis of the value of the variable, you can choose to call panic / fatal / warn, whatever you like and print the required message. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1638/#review3917 ----------------------------------------------------------- On Jan. 29, 2013, 2:34 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1638/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 2:34 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9515:1331b07a1479 > --------------------------- > stats: Add SQLite database as an output format > > This patch adds a second output format (in addition to the stats.txt) which > stores the stats in an SQLite database using SQLAlchemy. The information about > each stat is written to the database once to avoid repeated data. Each dump is > given an accociated dump ID which is based on the the number of dumps stored > in the database. > > To enable the SQL output, a parameter has been added to gem5. For example, > ./build/ARM/gem5.fast --stats-db-file=stats.db .... > will stored the stats in a file called "stats.db". By default SQL stats are > disabled. In order to disable the text-based stats output use --stats-file="". > For backwards compatibility the default behaviour creates stats.txt. > > In case SQLAlchemy is unavailable, only stats.txt is generated. If text-based > stats are explicitly disabled, gem5 will fatal. > > > Diffs > ----- > > src/python/SConscript 5532a1642108 > src/python/m5/main.py 5532a1642108 > src/python/m5/stats/__init__.py 5532a1642108 > src/python/m5/stats/sql.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/1638/diff/ > > > Testing > ------- > > Generated a number of databases > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
