----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1680/#review3959 -----------------------------------------------------------
Ship it! LGTM The summary could be more verbose :-) - Andreas Hansson On Jan. 29, 2013, 8:29 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1680/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 8:29 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9497:276ad773bc71 > --------------------------- > ruby: replace Time with Cycles in garnet fixed and flexible > > > Diffs > ----- > > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh 5dca39cc7641 > src/mem/ruby/network/garnet/BaseGarnetNetwork.cc 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.hh 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/OutVcState_d.hh 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.hh 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.cc 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/VirtualChannel_d.hh 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/VirtualChannel_d.cc 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/flitBuffer_d.hh 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/flitBuffer_d.cc 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/flit_d.hh 5dca39cc7641 > src/mem/ruby/network/garnet/fixed-pipeline/flit_d.cc 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/FlexibleConsumer.hh > 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/InVcState.hh 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/InVcState.cc 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.hh > 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/OutVcState.hh 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/OutVcState.cc 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/Router.hh 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/flit.hh 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/flit.cc 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/flitBuffer.hh 5dca39cc7641 > src/mem/ruby/network/garnet/flexible-pipeline/flitBuffer.cc 5dca39cc7641 > src/mem/ruby/network/simple/Throttle.hh 5dca39cc7641 > > Diff: http://reviews.gem5.org/r/1680/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
