----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1673/#review3964 -----------------------------------------------------------
src/mem/ruby/system/MemoryNode.hh <http://reviews.gem5.org/r/1673/#comment3828> This file uses Ref& name and I would suggest to stick with this throughout the file. src/mem/ruby/system/MemoryNode.hh <http://reviews.gem5.org/r/1673/#comment3829> Spacing around & - Andreas Hansson On Jan. 26, 2013, 8 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1673/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2013, 8 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9490:c8174f7f5ba4 > --------------------------- > ruby: replace Time with Cycles in Memory Controller > > > Diffs > ----- > > src/mem/ruby/system/MemoryControl.hh b0fa6b872f40 > src/mem/ruby/system/MemoryNode.hh b0fa6b872f40 > src/mem/ruby/system/RubyMemoryControl.hh b0fa6b872f40 > src/mem/ruby/system/RubyMemoryControl.cc b0fa6b872f40 > > Diff: http://reviews.gem5.org/r/1673/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
