----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1670/#review3966 -----------------------------------------------------------
Ship it! LGTM src/mem/ruby/slicc_interface/RubySlicc_Util.hh <http://reviews.gem5.org/r/1670/#comment3833> Related change? - Andreas Hansson On Jan. 26, 2013, 7:57 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1670/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2013, 7:57 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9487:5093d38a3114 > --------------------------- > ruby: replaces Time with Cycles in many places > The patch started of with replacing Time with Cycles in the Consumer class. > But to get ruby to compile, the rest of the changes had to be carried out. > Subsequent patches will further this process, till we completely replace > Time with Cycles. > > > Diffs > ----- > > src/mem/protocol/MESI_CMP_directory-L1cache.sm b0fa6b872f40 > src/mem/protocol/MESI_CMP_directory-L2cache.sm b0fa6b872f40 > src/mem/protocol/MESI_CMP_directory-dir.sm b0fa6b872f40 > src/mem/protocol/MESI_CMP_directory-dma.sm b0fa6b872f40 > src/mem/protocol/MI_example-cache.sm b0fa6b872f40 > src/mem/protocol/MI_example-dir.sm b0fa6b872f40 > src/mem/protocol/MI_example-dma.sm b0fa6b872f40 > src/mem/protocol/MOESI_CMP_directory-L1cache.sm b0fa6b872f40 > src/mem/protocol/MOESI_CMP_directory-L2cache.sm b0fa6b872f40 > src/mem/protocol/MOESI_CMP_directory-dir.sm b0fa6b872f40 > src/mem/protocol/MOESI_CMP_directory-dma.sm b0fa6b872f40 > src/mem/protocol/MOESI_CMP_token-L1cache.sm b0fa6b872f40 > src/mem/protocol/MOESI_CMP_token-L2cache.sm b0fa6b872f40 > src/mem/protocol/MOESI_CMP_token-dir.sm b0fa6b872f40 > src/mem/protocol/MOESI_CMP_token-dma.sm b0fa6b872f40 > src/mem/protocol/MOESI_hammer-cache.sm b0fa6b872f40 > src/mem/protocol/MOESI_hammer-dir.sm b0fa6b872f40 > src/mem/protocol/MOESI_hammer-dma.sm b0fa6b872f40 > src/mem/protocol/Network_test-cache.sm b0fa6b872f40 > src/mem/protocol/RubySlicc_Exports.sm b0fa6b872f40 > src/mem/protocol/RubySlicc_Types.sm b0fa6b872f40 > src/mem/protocol/RubySlicc_Util.sm b0fa6b872f40 > src/mem/ruby/buffers/MessageBuffer.hh b0fa6b872f40 > src/mem/ruby/buffers/MessageBuffer.cc b0fa6b872f40 > src/mem/ruby/buffers/MessageBufferNode.hh b0fa6b872f40 > src/mem/ruby/common/Consumer.hh b0fa6b872f40 > src/mem/ruby/common/Consumer.cc b0fa6b872f40 > src/mem/ruby/network/BasicLink.hh b0fa6b872f40 > src/mem/ruby/network/BasicLink.py b0fa6b872f40 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py b0fa6b872f40 > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.hh b0fa6b872f40 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > b0fa6b872f40 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh b0fa6b872f40 > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.hh b0fa6b872f40 > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc b0fa6b872f40 > src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc b0fa6b872f40 > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc b0fa6b872f40 > src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc b0fa6b872f40 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetLink.py b0fa6b872f40 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > b0fa6b872f40 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh b0fa6b872f40 > src/mem/ruby/network/garnet/flexible-pipeline/Router.hh b0fa6b872f40 > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc b0fa6b872f40 > src/mem/ruby/network/simple/PerfectSwitch.cc b0fa6b872f40 > src/mem/ruby/network/simple/Switch.hh b0fa6b872f40 > src/mem/ruby/network/simple/Switch.cc b0fa6b872f40 > src/mem/ruby/network/simple/Throttle.hh b0fa6b872f40 > src/mem/ruby/network/simple/Throttle.cc b0fa6b872f40 > src/mem/ruby/slicc_interface/AbstractCacheEntry.hh b0fa6b872f40 > src/mem/ruby/slicc_interface/AbstractController.hh b0fa6b872f40 > src/mem/ruby/slicc_interface/Controller.py b0fa6b872f40 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh b0fa6b872f40 > src/mem/ruby/system/Cache.py b0fa6b872f40 > src/mem/ruby/system/CacheMemory.hh b0fa6b872f40 > src/mem/ruby/system/RubyMemoryControl.hh b0fa6b872f40 > src/mem/ruby/system/RubyMemoryControl.cc b0fa6b872f40 > src/mem/ruby/system/RubyMemoryControl.py b0fa6b872f40 > src/mem/ruby/system/Sequencer.cc b0fa6b872f40 > src/mem/ruby/system/TimerTable.hh b0fa6b872f40 > src/mem/ruby/system/TimerTable.cc b0fa6b872f40 > src/mem/ruby/system/WireBuffer.hh b0fa6b872f40 > src/mem/ruby/system/WireBuffer.cc b0fa6b872f40 > src/mem/slicc/ast/EnqueueStatementAST.py b0fa6b872f40 > src/mem/slicc/ast/FuncCallExprAST.py b0fa6b872f40 > src/mem/slicc/ast/InfixOperatorExprAST.py b0fa6b872f40 > src/mem/slicc/symbols/StateMachine.py b0fa6b872f40 > src/mem/slicc/symbols/Type.py b0fa6b872f40 > > Diff: http://reviews.gem5.org/r/1670/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
