> On Feb. 1, 2013, 2:13 a.m., Andreas Hansson wrote: > > src/mem/protocol/MOESI_CMP_token-L1cache.sm, line 186 > > <http://reviews.gem5.org/r/1681/diff/1/?file=33736#file33736line186> > > > > Should this really be here? Is this not a ClockedObject? > > Nilay Vaish wrote: > Note that the statement appears in .sm file. The code in these files is > not aware > of what a clocked object means. There is at least one more way of doing > this. But I > think that would require some substantial change to how controllers are > defined in > SLICC. I am just taking the easy way out.
Makes sense. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1681/#review3958 ----------------------------------------------------------- On Jan. 29, 2013, 8:29 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1681/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 8:29 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9498:33dc5a179d7c > --------------------------- > ruby: replace Time with Cycles > This patch further replaces Time with Cycles in Sequencer, Profiler, > different protocols and related entities. > > > Diffs > ----- > > src/mem/protocol/MOESI_CMP_token-L1cache.sm 5dca39cc7641 > src/mem/protocol/MOESI_hammer-cache.sm 5dca39cc7641 > src/mem/protocol/MOESI_hammer-dir.sm 5dca39cc7641 > src/mem/protocol/MOESI_hammer-msg.sm 5dca39cc7641 > src/mem/protocol/RubySlicc_Exports.sm 5dca39cc7641 > src/mem/protocol/RubySlicc_Types.sm 5dca39cc7641 > src/mem/protocol/RubySlicc_Util.sm 5dca39cc7641 > src/mem/ruby/profiler/Profiler.hh 5dca39cc7641 > src/mem/ruby/profiler/Profiler.cc 5dca39cc7641 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh 5dca39cc7641 > src/mem/ruby/system/Sequencer.hh 5dca39cc7641 > src/mem/ruby/system/Sequencer.cc 5dca39cc7641 > src/mem/ruby/system/TBETable.hh 5dca39cc7641 > > Diff: http://reviews.gem5.org/r/1681/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
