----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1697/#review3994 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On Feb. 7, 2013, 3:35 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1697/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2013, 3:35 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9497:51712ef0d573 > --------------------------- > base: Fix broken IPython argument handling > > Prior to this changeset, we used to clear sys.argv before entering the > IPython shell. This caused some versions of IPython to crash because > they assume argv[0] to exist. The correct way of overriding the > arguments passed to IPython is to set the argv keyword argument when > initializing the shell. > > > Diffs > ----- > > src/python/m5/main.py 890fc69ba53c > > Diff: http://reviews.gem5.org/r/1697/diff/ > > > Testing > ------- > > Tested interactive shell with IPython 0.10. Tried to pass command line > options to the script as this was the original reason (presumably) for > zapping sys.argv. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
