----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1692/#review4005 -----------------------------------------------------------
Wasn't the switchroo test working before as well? IIRC it is part of the regression tests. - Nilay Vaish On Feb. 7, 2013, 8:02 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1692/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2013, 8:02 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9494:f490aefa53d3 > --------------------------- > cpu: Remove incorrect branch predictor drain checks > > The branch predictor unit incorrectly checked that the prediction > history was empty when the system is drained. This is an incorrect > assumption since the predictor isn't affected by a drain. > > > Diffs > ----- > > src/cpu/o3/fetch_impl.hh 890fc69ba53c > src/cpu/pred/bpred_unit.hh 890fc69ba53c > src/cpu/pred/bpred_unit_impl.hh 890fc69ba53c > > Diff: http://reviews.gem5.org/r/1692/diff/ > > > Testing > ------- > > Compiles. The ARM realview-switcheroo-full test case works. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
