> On March 12, 2013, 3:29 p.m., Andreas Hansson wrote: > > src/mem/ruby/profiler/Profiler.cc, line 260 > > <http://reviews.gem5.org/r/1760/diff/1/?file=34458#file34458line260> > > > > Should a print function not be const?
I'll mark it const. > On March 12, 2013, 3:29 p.m., Andreas Hansson wrote: > > src/mem/ruby/profiler/Profiler.cc, line 265 > > <http://reviews.gem5.org/r/1760/diff/1/?file=34458#file34458line265> > > > > You can use "auto" and save yourself some pain :-) I have already endured it! - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1760/#review4095 ----------------------------------------------------------- On March 8, 2013, 9:58 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1760/ > ----------------------------------------------------------- > > (Updated March 8, 2013, 9:58 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9587:3711cb4f4e9e > --------------------------- > ruby: keep histogram of outstanding requests in seq > The histogram for tracking outstanding counts per cycle is maintained > in the profiler. For a parallel implementation of the memory system, we > need that this histogram is maintained locally. Hence it will now be > kept in the sequencer itself. The resulting histograms will be merged > when the stats are printed. > > > Diffs > ----- > > src/mem/ruby/profiler/Profiler.hh e507dc092ca3 > src/mem/ruby/profiler/Profiler.cc e507dc092ca3 > src/mem/ruby/slicc_interface/AbstractController.cc e507dc092ca3 > src/mem/ruby/system/Sequencer.hh e507dc092ca3 > src/mem/ruby/system/Sequencer.cc e507dc092ca3 > > Diff: http://reviews.gem5.org/r/1760/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
