> On March 12, 2013, 3:28 p.m., Andreas Hansson wrote:
> > src/dev/x86/i8042.cc, line 414
> > <http://reviews.gem5.org/r/1759/diff/1/?file=34456#file34456line414>
> >
> > Is this something that happens at boot with never kernels? How
> > difficult would it be to implement it "properly"?
>
> Nilay Vaish wrote:
> You really think we need a keyboard or a mouse in a simulator!
> I am not implementing them anyway.
>
> Andreas Hansson wrote:
> I'm mostly curious why the behaviour changed.
The following lines were added to the file drivers/input/serio/i8042-x86ia64io.h
/*
* A20 was already enabled during early kernel init. But some buggy
* BIOSes (in MSI Laptops) require A20 to be enabled using 8042 to
* resume from S3. So we do it here and hope that nothing breaks.
*/
i8042_command(&a20_on, 0x10d1);
i8042_command(NULL, 0x00ff); /* Null command for SMM firmware */
- Nilay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1759/#review4094
-----------------------------------------------------------
On March 8, 2013, 9:57 a.m., Nilay Vaish wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1759/
> -----------------------------------------------------------
>
> (Updated March 8, 2013, 9:57 a.m.)
>
>
> Review request for Default.
>
>
> Description
> -------
>
> Changeset 9583:5919a10e6cdd
> ---------------------------
> x86: changes to apic, keyboard
> It is possible that operating system wants to shutdown the
> lapic timer by writing timer's initial count to 0. This patch
> adds a check that the timer event is only scheduled if the
> count is 0.
>
> The patch also converts few of the panics related to the keyboard
> to warnings since we are any way not interested in simulating the
> keyboard.
>
>
> Diffs
> -----
>
> src/arch/x86/interrupts.cc e507dc092ca3
> src/dev/x86/i8042.cc e507dc092ca3
>
> Diff: http://reviews.gem5.org/r/1759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Nilay Vaish
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
