> On March 22, 2013, 3:21 p.m., Nilay Vaish wrote: > > src/cpu/exetrace.cc, line 88 > > <http://reviews.gem5.org/r/1790/diff/1/?file=34602#file34602line88> > > > > Can you not just edit this condition to: > > > > debugSymbolTable && Debug::ExecSymbol && (!FullSystem || > > !inUserMode(thread)) > > && debugSymbolTable->findNearestSymbol(cur_pc, sym_str, sym_addr)
I wanted the trace to show both the symbol name and PC value for SE mode, which is why I have separate sections for full system and SE mode, but yes, we can merge the conditions as stated by you - Umesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1790/#review4152 ----------------------------------------------------------- On March 22, 2013, 3:04 p.m., Umesh Bhaskar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1790/ > ----------------------------------------------------------- > > (Updated March 22, 2013, 3:04 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9593:7f19afe10883 > --------------------------- > [mq]: patch_exetrace > Fixes the issue wherein Debug symbols were not getting dumped into trace > files for SE mode > > > Diffs > ----- > > src/cpu/exetrace.cc e63321487404 > > Diff: http://reviews.gem5.org/r/1790/diff/ > > > Testing > ------- > > > Thanks, > > Umesh Bhaskar > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
