> On March 25, 2013, 8:51 p.m., Steve Reinhardt wrote: > > src/mem/bus.hh, line 237 > > <http://reviews.gem5.org/r/1771/diff/2/?file=34538#file34538line237> > > > > Aren't portIDs small integers? Wouldn't a vector suffice, with NULL > > entries for ports that aren't waiting? > > > > Or maybe that's just the old C programmer in me showing through...
Very valid comment. We do know the size of the PortIDs in question, and a vector would probably be more efficient. Let me give it a shot. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1771/#review4167 ----------------------------------------------------------- On March 15, 2013, 10:10 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1771/ > ----------------------------------------------------------- > > (Updated March 15, 2013, 10:10 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9590:fc9c766646dd > --------------------------- > mem: Separate waiting for the bus and waiting for a peer > > This patch splits the retryList into a list of ports that are waiting > for the bus itself to become available, and a map that tracks the > ports where forwarding failed due to a peer not accepting the > packet. Thus, when a retry reaches the bus, it can be sent to the > appropriate port that initiated that transaction. > > As a consequence of this patch, only ports that are really ready to go > will get a retry, thus reducing the amount of redundant failed > attempts. This patch also makes it easier to reason about the order of > servicing requests as the ports waiting for the bus are now clearly > FIFO and much easier to change if desired. > > > Diffs > ----- > > src/mem/bus.hh ef864175dcc0 > src/mem/bus.cc ef864175dcc0 > src/mem/coherent_bus.hh ef864175dcc0 > src/mem/coherent_bus.cc ef864175dcc0 > src/mem/noncoherent_bus.hh ef864175dcc0 > src/mem/noncoherent_bus.cc ef864175dcc0 > > Diff: http://reviews.gem5.org/r/1771/diff/ > > > Testing > ------- > > With stats updates, all regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
