----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1799/#review4190 -----------------------------------------------------------
The patch seems fine. Andreas, did you figure out the reason for the slowdown observed in executing the regression tests? Can the change in the memory controller be a possible reason? - Nilay Vaish On March 28, 2013, 3:30 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1799/ > ----------------------------------------------------------- > > (Updated March 28, 2013, 3:30 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9624:aafbd0f38132 > --------------------------- > config: Add a mem-type config option to se/fs scripts > > This patch enables selection of the memory controller class through a > mem-type command-line option. Behind the scenes, this option is > treated much like the cpu-type, and a similar framework is used to > resolve the valid options, and translate the short-hand description to > a valid class. > > The regression scripts are updated with a hardcoded memory class for > the moment. The best solution going forward is probably to get the > memory out of the makeSystem functions, but Ruby complicates things as > it does not connect the memory controller to the membus. > > > Diffs > ----- > > configs/common/FSConfig.py 89aa34e10625 > configs/common/MemConfig.py PRE-CREATION > configs/common/Options.py 89aa34e10625 > configs/common/Simulation.py 89aa34e10625 > configs/example/fs.py 89aa34e10625 > configs/example/se.py 89aa34e10625 > tests/configs/alpha_generic.py 89aa34e10625 > tests/configs/arm_generic.py 89aa34e10625 > tests/configs/pc-simple-timing-ruby.py 89aa34e10625 > tests/configs/twosys-tsunami-simple-atomic.py 89aa34e10625 > tests/configs/x86_generic.py 89aa34e10625 > > Diff: http://reviews.gem5.org/r/1799/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
