----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1811/#review4199 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On April 5, 2013, 7:10 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1811/ > ----------------------------------------------------------- > > (Updated April 5, 2013, 7:10 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9627:cc159aa06eff > --------------------------- > Ruby System, Cache Recorder: Use delete [] for trace vars > > The cache trace variables are array allocated uint8_t* in the RubySystem and > the Ruby CacheRecorder, but the code used delete to free the memory, resulting > in Valgrind memory errors. Change these deletes to delete [] to get rid of the > errors. > > > Diffs > ----- > > src/mem/ruby/recorder/CacheRecorder.cc 3b51f4defa0d > src/mem/ruby/system/System.cc 3b51f4defa0d > > Diff: http://reviews.gem5.org/r/1811/diff/ > > > Testing > ------- > > Ran x86 FS in Valgrind to verify errors are gone. > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
