> On April 8, 2013, 6:59 a.m., Jason Power wrote: > >
I just now was looking at your other patch and I see that for the option maxtick the help says help="Stop after T ticks". This is ambiguous as to what the expected behavior is. Can you update the help message in this patch to clarify exactly what the behavior should be. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1815/#review4211 ----------------------------------------------------------- On April 7, 2013, 8:50 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1815/ > ----------------------------------------------------------- > > (Updated April 7, 2013, 8:50 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9632:63da4a862efd > --------------------------- > Simulation.py: Fix handling of maxtick and take_checkpoints > > m5.simulate(num_ticks) will run the simulated system for num_ticks after the > current tick. Fix calls to m5.simulate in scriptCheckpoints() and > benchCheckpoints() to appropriately handle the maxticks variable. > > > Diffs > ----- > > configs/common/Simulation.py fa31189e1fb5 > > Diff: http://reviews.gem5.org/r/1815/diff/ > > > Testing > ------- > > Tested repeated checkpointing and checkpoint restore with maxtick specified > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
