----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1821/#review4230 -----------------------------------------------------------
Ship it! Looks fine to me. Thank you for posting the change. My only concern is that there might be an issue running on a 64 bit host and simulating a 32 bit system or the reverse because the unsigned long that is being passed will be different lengths?? - Ali Saidi On April 10, 2013, 8:15 a.m., Michael Adler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1821/ > ----------------------------------------------------------- > > (Updated April 10, 2013, 8:15 a.m.) > > > Review request for Default. > > > Description > ------- > > Two patches for user mode (based on 20130123-gem5-stable-f75ee4849c40): > > - Implement getdents/getdents64 syscalls in user mode. > - Change mmap fixed address request to return an error if the mapping is > impossible due to conflict instead of what I believe used to be silent > corruption. > > > Diffs > ----- > > > Diff: http://reviews.gem5.org/r/1821/diff/ > > > Testing > ------- > > getdents is tested for Alpha. I implemented for other ISAs but did not > compile. > > mmap to fixed address is permitted to return an error if the address is > unavailable, so the change appears better than before. Workloads appear > stable. > > > Thanks, > > Michael Adler > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
