----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1676/#review4283 -----------------------------------------------------------
Ship it! Ship It! - Nathan Binkert On April 24, 2013, 3:20 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1676/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 3:20 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9705:bfac87aa5771 > --------------------------- > stats: Fix some bugs in the python based stats system > > This patch fixes assorted bugs in the python stats system. The following > bugs are addressed: > > The text-based stats output now overwrites the output stats file if it > exists on the first stats dump. If it does not exist, it is > created. The file is appended to on subsequent stats dumps. This > mimics the operation of the C++ based stats system. > > The total for a vector stat was not being calculated correctly as it > was calculating the sum of values including NaN and therefore any > vector which included a NaN summed to NaN. This operatino was not > desited as the old C++ based stats system ignored NaN values when > calculating the total. > > The total function in info now checks to see if the stat is a scalar > or a vector, and returns the corresponding total. > > Scalars and ScalarValues now have a length, mimicing the functionality > already found in Vector stats. > > This patch also addresses a typo in the code for VectorDist, and a > typo in the definition of a Value. > > > Diffs > ----- > > src/python/m5/stats/__init__.py 773aae0990ae > src/python/m5/stats/display.py PRE-CREATION > src/python/m5/stats/info.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/1676/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
