----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1841/#review4304 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On April 23, 2013, 12:33 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1841/ > ----------------------------------------------------------- > > (Updated April 23, 2013, 12:33 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9683:710b32378595 > --------------------------- > cpu: Move traffic generator sending out of generator states > > This patch moves the responsibility for sending packets out of the > generator states and leaves it with the top-level traffic > generator. The main aim of this patch is to enable a transition to > non-queued ports, i.e. with send/retry flow control, and to do so it > is much more convenient to not wrap the port interactions and instead > leave it all local to the traffic generator. > > The generator states now only govern when they are ready to send > something new, and the generation of the packets to send. They thus > have no knowledge of the port that is used. > > > Diffs > ----- > > src/cpu/testers/traffic_gen/generators.hh c5b24e8ed428 > src/cpu/testers/traffic_gen/generators.cc c5b24e8ed428 > src/cpu/testers/traffic_gen/traffic_gen.hh c5b24e8ed428 > src/cpu/testers/traffic_gen/traffic_gen.cc c5b24e8ed428 > > Diff: http://reviews.gem5.org/r/1841/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
