----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1839/ -----------------------------------------------------------
(Updated April 27, 2013, 12:16 p.m.) Review request for Default. Description (updated) ------- Changeset 9691:b59dda9aafad --------------------------- mem: Make returning snoop responses occupy response layer This patch introduces a mirrored internal snoop port to facilitate easy addition of flow control for the snoop responses that are turned into normal responses on their return. To perform this, the slave ports of the coherent bus are wrapped in internal master ports that are passed as the source ports to the response layer in question. As a result of this patch, there is more contention for the response resources, and as such system performance will decrease slightly. A consequence of the mirrored internal port is that the port the bus tells to retry (the internal one) and the port actually retrying (the mirrored) one are not the same. Thus, the existing check in tryTiming is not longer correct. In fact, the test is redundant as the layer is only in the retry state while calling sendRetry on the waiting port, and if the latter does not immediately call the bus then the retry state is left. Consequently the check is removed. Diffs (updated) ----- src/mem/bus.cc df8e64db0fd8 src/mem/coherent_bus.hh df8e64db0fd8 src/mem/coherent_bus.cc df8e64db0fd8 src/mem/port.hh df8e64db0fd8 Diff: http://reviews.gem5.org/r/1839/diff/ Testing ------- All regressions passing after minor stats updates Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
