----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1850/#review4315 -----------------------------------------------------------
Ship it! Minor name change, for the rest all good. src/cpu/kvm/base.hh <http://reviews.gem5.org/r/1850/#comment4076> I would suggest KVMCpuPort or similar to be more in line with the other CPU classes. - Andreas Hansson On May 2, 2013, 3:10 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1850/ > ----------------------------------------------------------- > > (Updated May 2, 2013, 3:10 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9685:edf659ee7b8a > --------------------------- > kvm: Fix the memory interface used by KVM > > The CpuPort class was removed before the KVM patches were committed, > which means that the KVM interface currently doesn't compile. This > changeset adds the BaseKvmCPU::MemPort class which derives from > MasterPort. This class is used on the data and instruction ports > instead of the old CpuPort. > > > Diffs > ----- > > src/cpu/kvm/base.hh 00dca8a9b560 > > Diff: http://reviews.gem5.org/r/1850/diff/ > > > Testing > ------- > > Compiles and boots Linux on X86. Haven't tested ARM, but there is no reason > it won't work. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
