----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1871/#review4343 -----------------------------------------------------------
src/mem/slicc/ast/TypeFieldMemberAST.py <http://reviews.gem5.org/r/1871/#comment4094> Why print field id twice? Instead add the field type. - Nilay Vaish On May 16, 2013, 9:27 p.m., Malek Musleh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1871/ > ----------------------------------------------------------- > > (Updated May 16, 2013, 9:27 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9704:3079f4134495 > --------------------------- > ruby: slicc: fix member name of TypeFieldMemberAST msg > > The member fields type_ptr, field_id are not defined, so when a MemberField > is duplicated, instead of SLICC indicating which TypeFieldMember is > duplicated, it outputs: > NameError: global name 'field_id' is not defined: > AttributeError: 'TypeFieldMemberAST' object has no attribute 'type_ptr': > > With this patch, during compilation, SLICC now indicates the protocol file > and Message FieldType that is duplicated. > > Testing: > > > Diffs > ----- > > src/mem/slicc/ast/TypeFieldMemberAST.py > 00dca8a9b5606900410248f998d28d36e4faf75b > > Diff: http://reviews.gem5.org/r/1871/diff/ > > > Testing > ------- > > > Thanks, > > Malek Musleh > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
