----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1869/#review4348 -----------------------------------------------------------
Does any one has comments to make? I am planning to commit it on Tuesday. - Nilay Vaish On May 11, 2013, 11:49 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1869/ > ----------------------------------------------------------- > > (Updated May 11, 2013, 11:49 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9687:bb1451fe594b > --------------------------- > x86: mark instructions for being function call/return > Currently call and return instructions are marked as IsCall and IsReturn. > Thus, the > branch predictor does not use RAS for these instructions. Similarly, the > number of > function calls that took place is recorded as 0. This patch marks these > instructions > as they should be. > > > Diffs > ----- > > src/arch/x86/isa/insts/general_purpose/control_transfer/call.py > eb075b2b925a > src/arch/x86/isa/insts/general_purpose/control_transfer/xreturn.py > eb075b2b925a > src/arch/x86/isa/macroop.isa eb075b2b925a > > Diff: http://reviews.gem5.org/r/1869/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
