----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1889/#review4384 -----------------------------------------------------------
Ship it! LGTM. Not sure about your question though. - Andreas Hansson On June 3, 2013, 4:29 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1889/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 4:29 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9734:068e76f5a9ad > --------------------------- > kvm: Maintain a local instruction counter and system->totalNumInsts > > Update the system's totalNumInst counter when exiting from KVM and > maintain internal an absolute instruction count instead of relying on > the one from perf. > > *** > > Notes to reviewers: I'm not sure about the semantics of totalInsts() and > totalOps() as their behavior is completely undocumented. It seems like they > used to be reset on a stat reset, but that code is commented out in the > BaseSimpleCPU. > > > Diffs > ----- > > src/cpu/kvm/base.hh 9d85dfa4696c > src/cpu/kvm/base.cc 9d85dfa4696c > > Diff: http://reviews.gem5.org/r/1889/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
