-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1892/#review4385
-----------------------------------------------------------



src/arch/generic/decode_cache.hh
<http://reviews.gem5.org/r/1892/#comment4115>

    Doxygen please :-)



src/cpu/decode_cache.hh
<http://reviews.gem5.org/r/1892/#comment4114>

    Is it sensible to even allow 0?



src/cpu/decode_cache.hh
<http://reviews.gem5.org/r/1892/#comment4113>

    >= rather than == ?


- Andreas Hansson


On June 3, 2013, 5:36 a.m., Andreas Sandberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1892/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 5:36 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Description
> -------
> 
> Changeset 9739:245243cf497d
> ---------------------------
> cpu: Limit the size of the decode cache
> 
> The decode cache can in some cases grow really large, which can even
> prevent some systems from booting. This changeset adds a the ability
> to limit the size of the decode cache and randomly prune a fraction of
> the cache once it reaches its upper limit. The default behavior on
> most architectures is now to allow 4k pages in the cache and prune 50%
> once this limit is reached.
> 
> 
> Diffs
> -----
> 
>   src/arch/generic/decode_cache.hh 304a37519d11 
>   src/arch/x86/decoder.hh 304a37519d11 
>   src/cpu/decode_cache.hh 304a37519d11 
> 
> Diff: http://reviews.gem5.org/r/1892/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sandberg
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to