> On June 1, 2013, 9:16 a.m., Nilay Vaish wrote: > > tests/SConscript, line 164 > > <http://reviews.gem5.org/r/1876/diff/1/?file=35487#file35487line164> > > > > Now that you have separate diff_status variable, I think the next 7-8 > > lines should be combined with code above where case analysis is being > > carried out on status.
Thanks for the input. It looks a lot cleaner now. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1876/#review4355 ----------------------------------------------------------- On June 3, 2013, 3:42 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1876/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 3:42 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9731:6297a376949f > --------------------------- > scons: Identify runs that fail and runs with stats differences > > This patch changes the regression script such that it is possible to > identify the runs that fail with an exit code, and those that finish > with stats differences. The ones that truly fail are reported as > FAILED, and those that finish with changed stats as CHANGED. > > The yellow colour has been reclaimed from the skipped regressions and > is now used for the changed ones. With no obvious good option left the > skipped ones are now in cyan. > > While I was editing the script I also bumped any occurence of M5 to > gem5. > > > Diffs > ----- > > tests/SConscript e2fafd224f43 > > Diff: http://reviews.gem5.org/r/1876/diff/ > > > Testing > ------- > > Ran a number of regressions with various levels of fail/change/pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
