----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1897/#review4411 -----------------------------------------------------------
src/mem/bridge.cc <http://reviews.gem5.org/r/1897/#comment4135> It's intentional. src/mem/bridge.cc <http://reviews.gem5.org/r/1897/#comment4134> True, it's mostly there to make it easy to interpret the code. I'll remove it and add a comment - Andreas Hansson On June 4, 2013, 10:50 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1897/ > ----------------------------------------------------------- > > (Updated June 4, 2013, 10:50 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9748:997f4168b8cc > --------------------------- > mem: Tidy up the bridge with const and additional checks > > This patch does a bit of tidying up in the bridge code, adding const > where appropriate and also removing redundant checks and adding a few > new ones. > > There are no changes to the behaviour of any regressions. > > > Diffs > ----- > > src/mem/Bridge.py ea26ba576891 > src/mem/bridge.hh ea26ba576891 > src/mem/bridge.cc ea26ba576891 > > Diff: http://reviews.gem5.org/r/1897/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
