----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1906/ -----------------------------------------------------------
Review request for Default. Description ------- Changeset 9748:d5a02eb2a87d --------------------------- ruby: remove the three files related to profiling This patch removes the following three files: RubySlicc_Profiler.sm, RubySlicc_Profiler_interface.cc and RubySlicc_Profiler_interface.hh. Only one function prototyped in the file RubySlicc_Profiler.sm. Rest of the code appearing in any of these files is not in use. Therefore, these files are being removed. That one single function, profileMsgDelay(), is being moved to the protocol files where it is in use. If we need any of these deleted functions, I think the right way to make them visible is to have the AbstractController class in a .sm and let the controller state machine inherit from this class. The AbstractController class can then have the prototypes of these profiling functions in its definition. Diffs ----- src/mem/ruby/slicc_interface/SConscript 3db869bbcdd1 src/mem/ruby/slicc_interface/RubySlicc_includes.hh 3db869bbcdd1 src/mem/ruby/slicc_interface/RubySlicc_Profiler_interface.cc 3db869bbcdd1 src/mem/ruby/slicc_interface/RubySlicc_Profiler_interface.hh 3db869bbcdd1 src/mem/protocol/RubySlicc_Profiler.sm 3db869bbcdd1 src/mem/protocol/RubySlicc_interfaces.slicc 3db869bbcdd1 src/mem/protocol/MI_example-cache.sm 3db869bbcdd1 src/mem/protocol/MESI_CMP_directory-L2cache.sm 3db869bbcdd1 src/mem/protocol/MESI_CMP_directory-L1cache.sm 3db869bbcdd1 Diff: http://reviews.gem5.org/r/1906/diff/ Testing ------- Thanks, Nilay Vaish _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
