----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1901/#review4412 -----------------------------------------------------------
LGTM except for the comment below. tests/configs/base_config.py <http://reviews.gem5.org/r/1901/#comment4136> Adding the mem_class parameter should really be in a separate commit or at least be mentioned in the commit message. - Andreas Sandberg On June 6, 2013, 2:33 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1901/ > ----------------------------------------------------------- > > (Updated June 6, 2013, 2:33 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9757:47d39456a0ec > --------------------------- > config: Add a BaseSESystem builder for re-use in regressions > > This patch extends the existing system builders to also include a > syscall-emulation base builder. To start with, this builder is only > deployed in a limited number of cases, most notably o3-timing, > simple-timing and simple-atomic. The main reason for this is to not > change any regressions. > > At this point only a uni-processor builder is added, and the values > chosen for the cache sizes match those that were used in the existing > config scripts (despite being on the large side). > > > Diffs > ----- > > tests/configs/base_config.py 101441a7b420 > tests/configs/inorder-timing.py 101441a7b420 > tests/configs/o3-timing-checker.py 101441a7b420 > tests/configs/o3-timing.py 101441a7b420 > tests/configs/simple-atomic-dummychecker.py 101441a7b420 > tests/configs/simple-atomic.py 101441a7b420 > tests/configs/simple-timing.py 101441a7b420 > tests/long/se/10.mcf/test.py 101441a7b420 > tests/long/se/20.parser/test.py 101441a7b420 > tests/long/se/30.eon/test.py 101441a7b420 > tests/long/se/40.perlbmk/test.py 101441a7b420 > tests/long/se/50.vortex/test.py 101441a7b420 > tests/long/se/60.bzip2/test.py 101441a7b420 > tests/long/se/70.twolf/test.py 101441a7b420 > tests/quick/se/00.hello/test.py 101441a7b420 > tests/quick/se/01.hello-2T-smt/test.py 101441a7b420 > tests/quick/se/02.insttest/test.py 101441a7b420 > tests/quick/se/20.eio-short/test.py 101441a7b420 > > Diff: http://reviews.gem5.org/r/1901/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
