----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1924/#review4434 -----------------------------------------------------------
src/mem/protocol/MOESI_CMP_token-L1cache.sm <http://reviews.gem5.org/r/1924/#comment4148> I think all changes to this file should be merged with the other patch. src/mem/slicc/symbols/SymbolTable.py <http://reviews.gem5.org/r/1924/#comment4146> If I understand this correctly, what you are saying that only frame 0 needs to be checked. Why is not possible that other frames have a symbol the 'id' of which clashes with the 'id' you just got? src/mem/slicc/symbols/SymbolTable.py <http://reviews.gem5.org/r/1924/#comment4147> It seems like this statement will allow you to override an earlier declared type with a newly declared type. Is this intentional? - Nilay Vaish On June 13, 2013, 2:43 p.m., Lena Olson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1924/ > ----------------------------------------------------------- > > (Updated June 13, 2013, 2:43 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9756:f4ebb213bbb4 > --------------------------- > ruby: fix slicc compiler to complain about duplicate symbols > > Previously, .sm files were allowed to use the same name for a type and a > variable. This is unnecessarily confusing and has some bad side effects, like > not being able to declare later variables in the same scope with the same > type. > This causes the compiler to complain and die on things like Address Address. > > > Diffs > ----- > > src/mem/protocol/MOESI_CMP_token-L1cache.sm 9df73385c878 > src/mem/slicc/symbols/SymbolTable.py 9df73385c878 > > Diff: http://reviews.gem5.org/r/1924/diff/ > > > Testing > ------- > > util/regress > --builds="ALPHA_MOESI_hammer,ALPHA_MESI_CMP_directory,ALPHA_MOESI_CMP_directory,ALPHA_MOESI_CMP_token,X86_MESI_CMP_directory" > --compile-variants="debug" after application of Changeset 9756:8956d858a9e6 > (review request 1921). > > > Thanks, > > Lena Olson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
