----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1899/#review4450 -----------------------------------------------------------
I am planning to commit this patch on Monday. - Nilay Vaish On June 4, 2013, 4:13 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1899/ > ----------------------------------------------------------- > > (Updated June 4, 2013, 4:13 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9745:bd183992b333 > --------------------------- > ruby: profiler: lots of inter-related changes > The patch started of with removing the global variables from the profiler for > profiling the miss latency of requests made to the cache. The corrresponding > histograms have been moved to the Sequencer. These are combined together when > the histograms are printed. > > A particular set of histograms used to use the Generic Machine Type defined > in one of the protocol files. This patch removes this type. Now, everything > that relied on this type would use MachineType instead. To do this, SLICC > has been changed so that multiple machine types can be declared by a > controller in its preamble. > > > Diffs > ----- > > src/mem/protocol/MI_example-cache.sm ea26ba576891 > src/mem/protocol/MOESI_CMP_token-L1cache.sm ea26ba576891 > src/mem/protocol/MOESI_hammer-cache.sm ea26ba576891 > src/mem/protocol/RubySlicc_ComponentMapping.sm ea26ba576891 > src/mem/protocol/RubySlicc_Exports.sm ea26ba576891 > src/mem/protocol/RubySlicc_Types.sm ea26ba576891 > src/mem/ruby/common/Histogram.cc ea26ba576891 > src/mem/ruby/profiler/Profiler.hh ea26ba576891 > src/mem/ruby/profiler/Profiler.cc ea26ba576891 > src/mem/ruby/system/Sequencer.hh ea26ba576891 > src/mem/ruby/system/Sequencer.cc ea26ba576891 > src/mem/slicc/ast/MachineAST.py ea26ba576891 > src/mem/slicc/parser.py ea26ba576891 > src/mem/slicc/symbols/Type.py ea26ba576891 > > Diff: http://reviews.gem5.org/r/1899/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
