----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1928/#review4454 -----------------------------------------------------------
src/sim/async.hh <http://reviews.gem5.org/r/1928/#comment4177> It might be useful to have a sim/systemc.hh with this conditional inclusion, maybe the #pragma ... system_header mechanism and any other handy definitions that I'm sure the SystemC interface will gain over time (#include <tlm> for instance!) - Andrew Bardsley On June 18, 2013, 8:43 a.m., Frédéric Konrad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1928/ > ----------------------------------------------------------- > > (Updated June 18, 2013, 8:43 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This allows Gem5 to be build with SystemC kernel when build with 'scons > sysc_build/*'. > > NOTE: There is a small bug with SystemC 2.3.0 which is the following: > > systemc-2.3.0/include/sysc/communication/sc_interface.h:72: error: > "__SUNPRO_CC" is not defined > > and can be fixed by replacing > > private: > static sc_event m_never_notified; > #if __SUNPRO_CC == 0x520 > // Workaround for a bug in the Sun WorkShop 6 update 2 compiler. > // An empty virtual base class can cause the optimizer to > // generate wrong code. > char dummy; > #endif > }; > > by > > private: > static sc_event m_never_notified; > #if defined(__SUNPRO_CC) && (__SUNPRO_CC == 0x520) > // Workaround for a bug in the Sun WorkShop 6 update 2 compiler. > // An empty virtual base class can cause the optimizer to > // generate wrong code. > char dummy; > #endif > }; > > > Diffs > ----- > > SConstruct UNKNOWN > src/base/pollevent.cc UNKNOWN > src/python/swig/event.i UNKNOWN > src/python/swig/pyevent.cc UNKNOWN > src/sim/async.hh UNKNOWN > src/sim/async.cc UNKNOWN > src/sim/eventq.hh UNKNOWN > src/sim/eventq.cc UNKNOWN > src/sim/init.cc UNKNOWN > src/sim/main.cc UNKNOWN > src/sim/simulate.hh UNKNOWN > src/sim/simulate.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/1928/diff/ > > > Testing > ------- > > > Thanks, > > Frédéric Konrad > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
