-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1931/
-----------------------------------------------------------

Review request for Default.


Repository: gem5


Description
-------

Changeset 9791:0946f340b959
---------------------------
mem: Reorganize cache tags and make them a SimObject

This patch reorganizes the cache tags to allow more flexibility to
implement new replacement policies. The base tags class is now a
clocked object so that derived classes can use a clock if they need
one. Also having deriving from SimObject allows specialized Tag
classes to be swapped in/out in .py files.

The cache set is now templatized to allow it to contain customized
cache blocks with additional informaiton. This involved moving code to
the .hh file and removing cacheset.cc.

The statistics belonging to the cache tags are now including ".tags"
in their name. Hence, the stats need an update to reflect the change
in naming.

Note that this follows on: http://reviews.gem5.org/r/1875/


Diffs
-----

  src/mem/cache/tags/lru.cc ff17ab994003 
  src/mem/cache/tags/lru.hh ff17ab994003 
  src/mem/cache/tags/fa_lru.cc ff17ab994003 
  src/mem/cache/tags/fa_lru.hh ff17ab994003 
  src/mem/cache/tags/cacheset.cc ff17ab994003 
  src/mem/cache/tags/cacheset.hh ff17ab994003 
  src/mem/cache/tags/base.cc ff17ab994003 
  src/mem/cache/tags/base.hh ff17ab994003 
  src/mem/cache/tags/Tags.py PRE-CREATION 
  src/mem/cache/tags/SConscript ff17ab994003 
  src/mem/cache/cache_impl.hh ff17ab994003 
  src/mem/cache/cache.hh ff17ab994003 
  src/mem/cache/base.cc ff17ab994003 
  src/mem/cache/BaseCache.py ff17ab994003 

Diff: http://reviews.gem5.org/r/1931/diff/


Testing
-------

After some sedding of the stats (for tag stats include .tags in the name) all 
regressions pass


Thanks,

Andreas Hansson

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to