----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1933/#review4473 -----------------------------------------------------------
SConstruct <http://reviews.gem5.org/r/1933/#comment4195> would be nice to mention here that python-config is why we need 2.5 SConstruct <http://reviews.gem5.org/r/1933/#comment4196> I found this whole comment a bit confusing, as it refers to things that aren't in the code below; I think it relies on context from the old code that won't be there anymore. Can you rewrite it to be more context-free? - Steve Reinhardt On June 26, 2013, 5:35 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1933/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 5:35 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9802:0816a8fb5ed8 > --------------------------- > scons: Use python-config instead of distutils > > This patch changes how we determine the Python-related compiler and > linker flags. The previous approach used the internal LINKFORSHARED > which is not intended as part of the external API > (http://bugs.python.org/issue3588) and causes failures on recent OSX > installations. > > Instead of using distutils we now rely on python-config and scons > ParseConfig. For backwards compatibility we also parse out the > includes and libs although this could safely be dropped. The drawback > of this patch is that Python 2.5 is now required, but hopefully that > is an acceptable compromise as any system with gcc 4.4 most likely > will have Python >= 2.5. > > > Diffs > ----- > > SConstruct 5fe711f40d18 > > Diff: http://reviews.gem5.org/r/1933/diff/ > > > Testing > ------- > > Compiled on OSX 10.8, RHE5, Ubuntu 10/12.04, OpenSUSE 12.3, Fedora19 > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
