----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1910/#review4497 -----------------------------------------------------------
Ship it! I don't know about the portability aspects of using __float80, but if others are satisfied with that issue, the rest of this patch looks fine to me. - Steve Reinhardt On June 11, 2013, 2:49 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1910/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 2:49 a.m.) > > > Review request for Default and Gabe Black. > > > Repository: gem5 > > > Description > ------- > > Changeset 9757:8b445d3198e0 > --------------------------- > x86: Add support for loading 32-bit and 80-bit floats in the x87 > > > *** Notes to reviewers *** > This changeset requires the presence of the __float80 type which is a GCC > extension, I'm not sure if this works with clang. I'll check that before > committing the patch. > > > Diffs > ----- > > src/arch/x86/isa/decoder/x87.isa 9df73385c878 > > src/arch/x86/isa/insts/x87/data_transfer_and_conversion/load_or_store_floating_point.py > 9df73385c878 > src/arch/x86/isa/microops/fpop.isa 9df73385c878 > src/arch/x86/isa/microops/ldstop.isa 9df73385c878 > > Diff: http://reviews.gem5.org/r/1910/diff/ > > > Testing > ------- > > Quick regressions pass. Solves a bug causing incorrect results in one of the > SPEC CPU2006 where the simulated x87 didn't store 32 bit floats correctly. > Tested loading and storing of 80-bit floats using a hand-coded assembly test > case that switched between a simulated CPU and a hardware CPU to exercise > loading and storing using the real thing as a reference. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
