----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1958/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 9818:132e2bbe723e --------------------------- cpu: Dynamically instantiate O3 CPU LSQUnits Previously, the LSQ would instantiate MaxThreads LSQUnits in the body of it's object, but it would only initialize numThreads LSQUnits as specified by the user. This had the effect of leaving some LSQUnits uninitialized when the number of threads was less than MaxThreads, and when adding statistics to the LSQUnit that must be initialized, this caused the stats initialization check to fail. By dynamically instantiating LSQUnits, they are all initialized and this avoids uninitialized LSQUnits from floating around during runtime. Diffs ----- src/cpu/o3/lsq.hh 971507cbbe65 src/cpu/o3/lsq_impl.hh 971507cbbe65 src/cpu/o3/lsq_unit_impl.hh 971507cbbe65 Diff: http://reviews.gem5.org/r/1958/diff/ Testing ------- Ran O3 regressions and tested checkpoint restore with additional LSQUnit stats. Thanks, Joel Hestness _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
