----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1963/#review4579 -----------------------------------------------------------
Hi Tony, Thanks for the patch. I ran into an issue where the bxj broke running on some systems (I think with thumb), so I've actually got a patch that reverts it I was thinking about posting. I don't know if you're run into this problem or it was something I did. Anyway, I'm happy with this change, but I just wanted to know if the resulting code was working for you even with it. Ali util/m5/Makefile.arm <http://reviews.gem5.org/r/1963/#comment4326> extra white space - Ali Saidi On Aug. 6, 2013, 6:19 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1963/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 6:19 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9818:42d960aece45 > --------------------------- > arm: use -march when compiling m5op_arm.S > > Using arm-linux-gnueabi-gcc 4.7.3-1ubuntu1 on Ubuntu 13.04 to compiled > the m5 binary yields the error: > > m5op_arm.S: Assembler messages: > m5op_arm.S:85: Error: selected processor does not support ARM mode `bxj lr' > > For each of of the SIMPLE_OPs. Apparently, this compiler doesn't like the > interworking of these code types for the default arch. Adding -march=armv7-a > makes it compile. Another alternative that I found to work is replacing the > bxj lr instruction with mov pc, lr, but I don't know how that affects the > KVM stuff and if bxj is needed. > > > Diffs > ----- > > util/m5/Makefile.arm 2492d7ccda7e145bb33930199c0a59886c96c324 > > Diff: http://reviews.gem5.org/r/1963/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
